Skip to content

Sheffield | 26-ITP-January | Martha Ogunbiyi | Sprint 1 | Wireframe #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
marthak1 wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Sheffield | 26-ITP-January | Martha Ogunbiyi | Sprint 1 | Wireframe #946

marthak1 wants to merge 13 commits into from
+113 −34

Conversation

@marthak1
Copy link

@marthak1 marthak1 commented Jan 13, 2026 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Summary

The purpose of this project is to take a wireframe and express it in web code.

Changes

  • added two more sections to create three articles and added links
  • styled the hyperlinks as buttons
  • added images to articles
  • styled header and, footer to fixed viewport

References

Sprint 1 Backlog – Task: Wireframe to Web Code

@netlify
Copy link

netlify bot commented Jan 13, 2026 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 2e14c32
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/696c0b7967b51e00085fba56
😎 Deploy Preview https://deploy-preview-946--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (🟢 up 5 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

Sign in to view
@marthak1 marthak1 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 13, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 13, 2026
@marthak1 marthak1 changed the title Sheffield | 26-ITP-Jan | Martha Ogunbiyi | Sprint 1 | Wireframe to Web Code Sheffield | 26-ITP-January | Martha Ogunbiyi | Sprint 1 | Wireframe to Web Code Jan 13, 2026
@github-actions

This comment has been minimized.

Sign in to view
@marthak1 marthak1 changed the title Sheffield | 26-ITP-January | Martha Ogunbiyi | Sprint 1 | Wireframe to Web Code Sheffield | JAN-2026 | Martha Ogunbiyi | Sprint 1 | Wireframe to Web Code Jan 13, 2026
@github-actions

This comment has been minimized.

Sign in to view
@marthak1 marthak1 changed the title Sheffield | JAN-2026 | Martha Ogunbiyi | Sprint 1 | Wireframe to Web Code Sheffield | ITP-January-26 | Martha Ogunbiyi | Sprint1 | Wireframe to Web Code Jan 13, 2026
@github-actions

This comment has been minimized.

Sign in to view
@marthak1 marthak1 changed the title Sheffield | ITP-January-26 | Martha Ogunbiyi | Sprint1 | Wireframe to Web Code Sheffield | 26-ITP-January | Martha Ogunbiyi | Sprint 1 | Wireframe to Web Code Jan 13, 2026
@github-actions

This comment has been minimized.

Sign in to view
@marthak1 marthak1 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 13, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 13, 2026
@marthak1 marthak1 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 13, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 13, 2026
@marthak1 marthak1 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 13, 2026
@marthak1 marthak1 changed the title Sheffield | 26-ITP-January | Martha Ogunbiyi | Sprint 1 | Wireframe to Web Code Sheffield | 26-ITP-January | Martha Ogunbiyi | Sprint 1 | Wireframe Jan 13, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 13, 2026
@github-actions

This comment has been minimized.

Sign in to view
@marthak1 marthak1 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 13, 2026
cjyuan
cjyuan reviewed Jan 20, 2026
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great.

There are some minor improvements you can still possibly made. If time permits, ask AI for possible improvements in terms of semantic, accessibility, typo, and consistency. AI, as a tool, can often help us catch errors, improve consistency, and reinforce best practices.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marthak1 @cjyuan